Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3456] Move address query UI in a separate page #4788

Merged
merged 5 commits into from
Sep 26, 2024
Merged

[ADP-3456] Move address query UI in a separate page #4788

merged 5 commits into from
Sep 26, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Sep 23, 2024

This PR separates out the address query from the wallet details. This makes the navigation bar depends on the resource state.

ADP-3456

@paolino paolino added Deposit UI UI related changes labels Sep 23, 2024
@paolino paolino self-assigned this Sep 23, 2024
HeinrichApfelmus
HeinrichApfelmus approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 😊

@paolino paolino force-pushed the paolino/ADP-3450/make-copying-work-on-mobile branch from 37430a3 to 4ca589b Compare September 25, 2024 16:26
@paolino paolino force-pushed the paolino/ADP-3456/move-address-query-in-a-separate-page branch from 5f20dec to 036b8d5 Compare September 25, 2024 16:26
Base automatically changed from paolino/ADP-3450/make-copying-work-on-mobile to paolino/ADP-3454/smooth-data-swapping-in-UI September 26, 2024 05:47
@paolino
[ADP-3457] Adapt long text to media (#4789)
2191cf2 
This PR change the shown length of addresses and hashes in general
depending on the media point. Also remove unneeded headers left around

ADP-3457
Base automatically changed from paolino/ADP-3454/smooth-data-swapping-in-UI to master September 26, 2024 07:49
@paolino paolino added this pull request to the merge queue Sep 26, 2024
Merged via the queue into master with commit 79830a3 Sep 26, 2024
22 checks passed
@paolino paolino deleted the paolino/ADP-3456/move-address-query-in-a-separate-page branch September 26, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
Deposit UI UI related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus